FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,android: Added option to compile for Android with -fPIE flag by bsegault · Pull Request #5783 · nodejs/node · GitHub

/ node Public

build,android: Added option to compile for Android with -fPIE flag - #5783

Closed
bsegault wants to merge 1 commit into
nodejs:masterfrom
bsegault:feature/android-PIE-flags
Closed

build,android: Added option to compile for Android with -fPIE flag#5783
bsegault wants to merge 1 commit into
nodejs:masterfrom
bsegault:feature/android-PIE-flags

Conversation

Copy link
Copy Markdown

Description of change

Hi,

Node for Android wasn't executable using the actual android-configure file. I made this PR using @kikijhu proposition and it builds fine on Linux (see #3581).

The created executable is PIE, and thus working on Android L & M (both tested).

I welcome any improvement you can make to this PR.

mscdex added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM architecture. labels Mar 18, 2016

mscdex commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

I think you linked to the wrong issue?

Also is the addition of --without-snapshot necessary?

Copy link
Copy Markdown
Contributor

FYI: as author of the linked issue, I can confirm that has nothing to do with this PR.

Copy link
Copy Markdown
Author

Hum, sorry for the wrong issue mention... Dunno what happened; first post updated.
@mscdex --without-snapshot allowed me to complete the build. I get a weird syntax error on a ) when I ommit it. Will post a log output for this error next monday if you want.

kikijhu commented Mar 21, 2016

Copy link
Copy Markdown

@mscdex as @bsegault said, if use --with-snapshot, we can't build pass for Android.

Here is the build log.

/home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: 1: /home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: Syntax error: word unexpected (expecting ")")
make[1]: *** [/home/kiki/node.js/node-v5.4.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc] Error 2
make[1]: Leaving directory `/home/kiki/node.js/node-v5.4.1/out'
make: *** [node] Error 2

rvagg commented Mar 22, 2016

Copy link
Copy Markdown
Member

I'm seeking some feedback about how Node.js is used on Android if anyone watching this thread would like to tell us about it: nodejs/build#359

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

Copy link
Copy Markdown
Member

Closing, obsoleted by #5544 which landed in commit 271201f. We're building with -fPIE -fpie now so this should be working.

bnoordhuis closed this May 2, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm Issues and PRs related to the ARM architecture. build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL