| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I think you linked to the wrong issue? Also is the addition of --without-snapshot necessary? |
Sorry, something went wrong.
|
FYI: as author of the linked issue, I can confirm that has nothing to do with this PR. |
Sorry, something went wrong.
|
Hum, sorry for the wrong issue mention... Dunno what happened; first post updated. |
Sorry, something went wrong.
|
@mscdex as @bsegault said, if use --with-snapshot, we can't build pass for Android. Here is the build log. /home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: 1: /home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: Syntax error: word unexpected (expecting ")") |
Sorry, something went wrong.
|
I'm seeking some feedback about how Node.js is used on Android if anyone watching this thread would like to tell us about it: nodejs/build#359 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description of change
Hi,
Node for Android wasn't executable using the actual android-configure file. I made this PR using @kikijhu proposition and it builds fine on Linux (see #3581).
The created executable is PIE, and thus working on Android L & M (both tested).
I welcome any improvement you can make to this PR.