Review requested:

• @nodejs/node-api

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.15%. Comparing base (795dd8e) to head (66c68ed).
Report is 51 commits behind head on main.

@@            Coverage Diff             @@
##             main   #57834      +/-   ##
==========================================
- Coverage   90.24%   90.15%   -0.09%     
==========================================
  Files         630      628       -2     
  Lines      185470   185036     -434     
  Branches    36375    36234     -141     
==========================================
- Hits       167371   166823     -548     
- Misses      10993    11164     +171     
+ Partials     7106     7049      -57     

... and 50 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/66226/

CI: https://ci.nodejs.org/job/node-test-pull-request/66250/

The build fails because VS2022 build for ARM64 hits out of memory issue:

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\tuple(132,1): fatal  error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\type_traits(1527,92): fatal  error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]

I wonder if it is a known issue and someone is looking at it, or I should see where to add the /Zm compiler option to limit the memory use.

CI: https://ci.nodejs.org/job/node-test-pull-request/66274/

The build fails because VS2022 build for ARM64 hits out of memory issue:

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\tuple(132,1): fatal  error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\type_traits(1527,92): fatal  error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]

I wonder if it is a known issue and someone is looking at it, or I should see where to add the /Zm compiler option to limit the memory use.

Hello. Yes, this is a known problem, although it doesn't occur often. We are already setting /Zm2000. It could be increased e.g., /Zm3000, but that will probably not be necessary. The reason for this is that in Node.js v24 and later, we'll be moving from MSVC to ClangCL. This is a PR making it official which should land sometime this week. With ClangCL, we are not using PCH, as we have enabled ccache, so this will not be an issue.

I have restarted CI for this, so let's see if it succeeds this time.

Landed in c326200

@StefanStojanovic and @lpinca , thank you for helping with the PR completion!