FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: match minimum file column to 'all files' by islandryu · Pull Request #57848 · nodejs/node · GitHub

/ node Public

test_runner: match minimum file column to 'all files' - #57848

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:fix/filenameColum
Apr 14, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: match minimum file column to 'all files'#57848
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:fix/filenameColum

Conversation

islandryu commented Apr 12, 2025

Copy link
Copy Markdown
Member

Fixed a problem that all files are omitted when the file name displayed in coverage is too short.

ℹ tests 1
ℹ suites 0
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 3.993167
ℹ start of coverage report
ℹ ------------------------------------------------------------------------------------
ℹ file   | line % | branch % | funcs % | uncovered lines
ℹ ------------------------------------------------------------------------------------
ℹ a.js   |  55.77 |   100.00 |    0.00 | 5-7 9-11 13-15 17-19 29-30 40-42 45-47 50-52
ℹ ------------------------------------------------------------------------------------
ℹ …files |  55.77 |   100.00 |    0.00 | 
ℹ ------------------------------------------------------------------------------------
ℹ end of coverage report

nodejs-github-bot commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 12, 2025

codecov Bot commented Apr 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (86f86a2) to head (697228d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/utils.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57848      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185481   185481              
  Branches    36364    36369       +5     
==========================================
+ Hits       167357   167386      +29     
+ Misses      11004    11000       -4     
+ Partials     7120     7095      -25
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 58.52% <0.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini approved these changes Apr 13, 2025
View reviewed changes

pmarchini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution!!!
LGTM!

nodejs-github-bot commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66238/

pmarchini added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 13, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2025
nodejs-github-bot merged commit f89baf2 into nodejs:main Apr 14, 2025

nodejs-github-bot commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in f89baf2

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
test_runner: match minimum file column to 'all files'
b4908e3 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
test_runner: match minimum file column to 'all files'
7416a7f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test_runner: match minimum file column to 'all files'
6025917 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test_runner: match minimum file column to 'all files'
5ef665f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
test_runner: match minimum file column to 'all files'
0a61b78 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
test_runner: match minimum file column to 'all files'
abdaa33 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
test_runner: match minimum file column to 'all files'
cf58fa5 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
test_runner: match minimum file column to 'all files'
b0097db 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
test_runner: match minimum file column to 'all files'
edb7dd1 
PR-URL: #57848
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
jakecastelli jakecastelli approved these changes
pmarchini pmarchini approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL