Backport of 5528 - #5785
Conversation
Sorry, something went wrong.
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: nodejs#5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: nodejs#548 PR-URL: nodejs#5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
LGTM if ci is green |
Sorry, something went wrong.
Sorry, something went wrong.
|
LGTM. Unrelated test failure on ARM. How are we going to test this on the CI? EDIT: By which I mean: how are we going to test the new Makefile target on the CI? |
Sorry, something went wrong.
|
Don't want to hijack the comment thread here, but the flaky ARM failure above is fixed in #5728 but that PR still needs a LGTM from a collaborator. Feel free to review! |
Sorry, something went wrong.
|
@joaocgreis would it be possible to get a CI job setup to run this, independent of any other jobs? |
Sorry, something went wrong.
|
@cjihrig An alternative to getting a custom CI job could be to create a new branch from this one, change make test-ci (and equivalent in vcbuild.bat) to be the same as the target you want to run, and run a test job against that commit/branch. |
Sorry, something went wrong.
|
@Trott that does not work for the fanned jobs. Because they have to archive binaries, test-ci is not used. I created a new job (slow, no cross-compiling), here is the first run: https://ci.nodejs.org/job/node-test-known-issues/1/ . There seems to be something wrong with one win2008 machine, I'll have to take a look at it. Does not seem related to this. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This is a backport of #5528 (test: add a place for reproducing known bugs) to the v4.x-staging branch, at @thealphanerd request.