| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
it'd be great to get a PR that just fixes the value-named functions and disables the lint rule so that it can be released and maximally backported. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #57901 +/- ##
==========================================
+ Coverage 90.05% 90.32% +0.26%
==========================================
Files 714 730 +16
Lines 225876 234165 +8289
Branches 42737 43912 +1175
==========================================
+ Hits 203408 211501 +8093
- Misses 14244 14372 +128
- Partials 8224 8292 +68
... and 114 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
Hello, I've worked on the eslint rule for this one, i've just made some changes with the eslint's func-name-matching rule, and its ruletester. You can check the work here: lib-name-functions Let me know if you guys have any thoughts on this :>, and if all is good, i could send a PR to this PR's branch. |
Sorry, something went wrong.
|
@louiellan sorry for the late response.
Yes, the code in your branch LGTM!
Small adjustments:
- the test's filename should start with `test-`, i.e. `func-name-matching.test.js` should be renamed to something like `test-eslint-func-name-matching.js`.
- i think the `@author` comments should be in separate lines (with multiple `@author` tags) rather than comma-separated.
Please feel free to open a PR either against this branch, or directly against main branch (not preserving my commit is also okay). Or i can merge your commits into this PR once am on PC (probably mid-August). Thank you!
|
Sorry, something went wrong.
|
@LiviaMedeiros I've made the adjustments and here's the pull request to your branch, LiviaMedeiros#1 |
Sorry, something went wrong.
Sorry, something went wrong.
|
Hello, feel free to ping me if this needs to be merged, this might be blocked because of the Signed-off-by requirement |
Sorry, something went wrong.
|
@louiellan apologies for late response and thank you! |
Sorry, something went wrong.
|
Now that you mentioned it, I realized that i only handled the explicit naming but not the concise notation functions (I'll work on it) but we still need to have a separate node-core version here fixing also the same thing 'cause of primordials as per submitting the rule to eslint, we'll need to make non-nodejs one (will work on it as well, I'll just mention you there and reference also the issue you made) |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
There was a problem hiding this comment.
nice improvement
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Louie Llaneta <louie.lou.llaneta@gmail.com>
|
Commit linting is failing |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/73698/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/29233234906 |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
And rename functions accordingly. Signed-off-by: LiviaMedeiros <livia@cirno.name> Co-authored-by: louiellan <louie.lou.llaneta@gmail.com> PR-URL: #57901 Refs: #57899 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
And rename functions accordingly. Signed-off-by: LiviaMedeiros <livia@cirno.name> Co-authored-by: louiellan <louie.lou.llaneta@gmail.com> PR-URL: #57901 Refs: #57899 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
And rename functions accordingly. Signed-off-by: LiviaMedeiros <livia@cirno.name> Co-authored-by: louiellan <louie.lou.llaneta@gmail.com> PR-URL: #57901 Refs: #57899 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
And rename functions accordingly. Signed-off-by: LiviaMedeiros <livia@cirno.name> Co-authored-by: louiellan <louie.lou.llaneta@gmail.com> PR-URL: #57901 Refs: #57899 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
| Back | FazBrowse Home | New Git URL |
Refs: #57899
This PR adds a node-core/func-name-matching linter rule that correctly handles defining properties with functions as value, and fixes the function names accordingly.
Authored by @louiellan