http2: give name to promisified connect() - #57913
Closed
LiviaMedeiros wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RafaelGSS
approved these changes
Apr 17, 2025
Copy link
Copy Markdown
Member
Author
|
Changing to draft, this should be implemented differently. |
Sorry, something went wrong.
LiviaMedeiros
marked this pull request as draft
April 17, 2025 16:39
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #57913 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 630 630
Lines 185786 185928 +142
Branches 36426 36434 +8
==========================================
+ Hits 167653 167804 +151
- Misses 11001 11021 +20
+ Partials 7132 7103 -29
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #57899 for the eslint exception.