Thanks, please wrap lines at 80 characters if that's not too much work. It could also be be nice to expand a little here.

I'll fix the long line, thanks for pointing that out. I was going to expand further with more examples in a different PR fixing #5747. Would adding more examples in a separate PR be preferred?

I think one PR is fine but @Trott is more experienced here than I.

Ok, I'll wait until he chimes in before adding the additional examples.

One PR is fine as long as the changes are all relevant to the same issue. There can be multiple commits if necessary.

One PR is fine in this case, but two is also fine, and since you already have it as two, maybe leave it as that. As this is your first commit (right?), it might be best to keep it small anyway so we can focus on process and not endless nits on grammar and style.

LGTM. If you can squash the two commits down to one and force push, that would be great. If not, whoever lands this can do it.

@Trott I've added your suggestion and squashed my commits into one and should be good to go. I'll add the extra examples on #5747.

Still LGTM.

Nit: The body of the commit message should probably be a sentence explaining the change rather than the first line of the commits that we're squashed.

Thanks for the contribution @eversojk ! Landed in d16d904

@benjamingr Thanks! Also thanks for your input @jasnell @Trott