FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add ALS test using http agent keep alive by Flarna · Pull Request #58017 · nodejs/node · GitHub

/ node Public

test: add ALS test using http agent keep alive - #58017

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Flarna:als-http-tests
Apr 27, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test: add ALS test using http agent keep alive#58017
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Flarna:als-http-tests

Conversation

Flarna commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Add a test to verify AsyncLocalStore functionality for HTTP using a keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on async_hooks tests alone is not longer valid.

Refs: #55712
Refs: #13325

Flarna added the async_local_storage AsyncLocalStorage label Apr 25, 2025
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 25, 2025
Flarna force-pushed the als-http-tests branch 2 times, most recently from 370b595 to 9b3271b Compare April 25, 2025 07:08
Flarna mentioned this pull request Apr 25, 2025
Closed
lpinca approved these changes Apr 25, 2025
View reviewed changes
Comment thread test/parallel/test-async-local-storage-http-agent.js Outdated

lpinca commented Apr 25, 2025

Copy link
Copy Markdown
Member

"Add a tests" -> "Add a test" in commit message.

test: add ALS test using http agent keep alive
887ae7a 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

codecov Bot commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (b665127) to head (887ae7a).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58017   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         630      630           
  Lines      186158   186158           
  Branches    36475    36472    -3     
=======================================
+ Hits       168047   168049    +2     
+ Misses      10980    10979    -1     
+ Partials     7131     7130    -1

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025

nodejs-github-bot commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66448/

Flarna added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 25, 2025
Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
nodejs-github-bot merged commit e716081 into nodejs:main Apr 27, 2025

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

Landed in e716081

Flarna deleted the als-http-tests branch April 27, 2025 10:46
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
test: add ALS test using http agent keep alive
416f503 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
test: add ALS test using http agent keep alive
b8b0192 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: add ALS test using http agent keep alive
88c345c 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: add ALS test using http agent keep alive
9768454 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
test: add ALS test using http agent keep alive
71e9189 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
test: add ALS test using http agent keep alive
e63c084 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
test: add ALS test using http agent keep alive
49d8dd3 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
test: add ALS test using http agent keep alive
62c9e2a 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
test: add ALS test using http agent keep alive
cbd5768 
Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.

PR-URL: #58017
Refs: #55712
Refs: #13325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

async_local_storage AsyncLocalStorage author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL