src: improve parsing of boolean options - #58039
Merged
nodejs-github-bot merged 3 commits intoApr 30, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
geeksilva97
force-pushed
the
improve-boolean-parsing
branch
from
bf2dcc5 to
01cedaa
Compare
April 26, 2025 17:59
Copy link
Copy Markdown
Contributor
Author
|
This allows passing inspect flag as a boolean. Which I think is the best we can do for now in node_config_file since the env_options_map holds tne --inspect entry as a boolean.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58039 +/- ##
==========================================
- Coverage 90.26% 90.20% -0.06%
==========================================
Files 630 630
Lines 186159 186446 +287
Branches 36474 36620 +146
==========================================
+ Hits 168036 168189 +153
- Misses 10974 11044 +70
- Partials 7149 7213 +64
... and 54 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Comment thread
test/parallel/test-config-file.js
Outdated
Comment thread
src/node_config_file.cc
Copy link
Copy Markdown
Member
|
LGTM with the require('node:inspector').url() suggestion |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
will do |
Sorry, something went wrong.
Comment thread
test/parallel/test-config-file.js
Outdated
Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
approved these changes
Apr 30, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/58039 ✔ Done loading data for nodejs/node/pull/58039 ----------------------------------- PR info ------------------------------------ Title src: improve parsing of boolean options (#58039) Author Edy Silva <edigleyssonsilva@gmail.com> (@geeksilva97) Branch geeksilva97:improve-boolean-parsing -> nodejs:main Labels c++, author ready, commit-queue-squash, config Commits 3 - src: improve parsing of boolean options - test: update test - fixup: remove unneeded flag Committers 2 - Edy Silva <edigleyssonsilva@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 26 Apr 2025 17:58:37 GMT ✔ Approvals: 1 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58039#pullrequestreview-2807571351 ✘ This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-30T16:10:21Z: https://ci.nodejs.org/job/node-test-pull-request/66517/ - Querying data for job/node-test-pull-request/66517/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14761825273 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It needs 1 more approval to land or has to wait a few more days |
Sorry, something went wrong.
cjihrig
approved these changes
Apr 30, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #57960
This PR changes the way booleans are parsed from the config file. Instead of setting --flag=true|false, it adds or not the flag to the options