FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add missing newlines to repl .exit writes by dario-piotrowicz · Pull Request #58041 · nodejs/node · GitHub

/ node Public

test: add missing newlines to repl .exit writes - #58041

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/test-repls-exits
Apr 28, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test: add missing newlines to repl .exit writes#58041
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/test-repls-exits

Conversation

dario-piotrowicz commented Apr 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I noticed that some repl tests write ".exit" in the repl, without a newline character (\n), as far as I can tell such write operations don't have any effect (removing those lines don't cause any test failures (AFAICT)).

I'm adding the missing newline characters so that the exit command is actually executed.

As part of this I'm also removing some end calls applied to the repl streams that are no longer necessary.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 26, 2025
dario-piotrowicz commented Apr 26, 2025
View reviewed changes
Comment thread test/parallel/test-repl-function-definition-edge-case.js Outdated

dario-piotrowicz Apr 26, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this new mustCall assertion is unnecessary, I can remove it if people don't like this addition

Note: prior to the \n addition this would cause the test to fail

test: add missing newlines to repl .exit writes
e8e2d7a 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

dario-piotrowicz commented Apr 26, 2025

Copy link
Copy Markdown
Member Author

Alternatively is preferred the various .exit writes could be removed since, as I mentioned, I don't think they serve any purpose (please do correct me if I'm wrong 😅)

But I think that keeping them in is the more correct solution 🙂

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2025

nodejs-github-bot commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66473/

codecov Bot commented Apr 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (b673c69) to head (e8e2d7a).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58041      +/-   ##
==========================================
- Coverage   90.28%   90.27%   -0.01%     
==========================================
  Files         630      630              
  Lines      186150   186328     +178     
  Branches    36468    36510      +42     
==========================================
+ Hits       168059   168205     +146     
- Misses      10975    11009      +34     
+ Partials     7116     7114       -2

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66481/

jakecastelli added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 28, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2025
nodejs-github-bot merged commit 53abd1a into nodejs:main Apr 28, 2025

nodejs-github-bot commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

Landed in 53abd1a

dario-piotrowicz deleted the dario/test-repls-exits branch April 28, 2025 21:01
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
test: add missing newlines to repl .exit writes
e8572c9 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
test: add missing newlines to repl .exit writes
3d708e0 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: add missing newlines to repl .exit writes
a6e1d57 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: add missing newlines to repl .exit writes
8a28267 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
test: add missing newlines to repl .exit writes
d92b80a 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
test: add missing newlines to repl .exit writes
ba627e7 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
test: add missing newlines to repl .exit writes
8c4cef2 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
test: add missing newlines to repl .exit writes
2549398 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
test: add missing newlines to repl .exit writes
2f4e416 
some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
jakecastelli jakecastelli approved these changes
+1 more reviewer
bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL