tools: ignore V8 tests in CodeQL scans - #58081
Merged
nodejs-github-bot merged 1 commit intoMay 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans.
targos
approved these changes
Apr 30, 2025
Copy link
Copy Markdown
Member
Author
|
I tested this with a GitHub Actions run on my own fork. The output of the run can be viewed at https://github.com/Trott/io.js/actions/runs/14747812391/job/41398383593. |
Sorry, something went wrong.
trivikr
approved these changes
Apr 30, 2025
cjihrig
approved these changes
Apr 30, 2025
mhdawson
approved these changes
Apr 30, 2025
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lpinca
approved these changes
Apr 30, 2025
anonrig
approved these changes
May 1, 2025
bjohansebas
approved these changes
May 1, 2025
bjohansebas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why don't we do this for the other dependencies?
Sorry, something went wrong.
atlowChemi
approved these changes
May 1, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans. PR-URL: #58081 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL reports hundreds of errors in V8 tests indicating 'A parse error occurred'. Code quality issues (real or spurious) in V8 tests are not a concern for Node.js. Exclude the tests from CodeQL scans.