doc: update return types for eventNames method in EventEmitter - #58083
Merged
nodejs-github-bot merged 2 commits intoMay 4, 2025
Merged
doc: update return types for eventNames method in EventEmitter#58083nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58083 +/- ##
==========================================
+ Coverage 89.67% 90.21% +0.54%
==========================================
Files 630 630
Lines 186445 186446 +1
Branches 36310 36614 +304
==========================================
+ Hits 167190 168198 +1008
+ Misses 11998 11049 -949
+ Partials 7257 7199 -58
... and 100 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
BridgeAR
approved these changes
Apr 30, 2025
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
lpinca
approved these changes
Apr 30, 2025
anonrig
approved these changes
May 1, 2025
LiviaMedeiros
approved these changes
May 1, 2025
Comment thread
doc/api/events.md
Outdated
Co-authored-by: Livia Medeiros <livia@cirno.name>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
May 1, 2025
Flarna
approved these changes
May 4, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58083 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58083 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the documentation for emitter.eventNames() to clarify that it returns (string | symbol)[].