crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL - #58103
Merged
nodejs-github-bot merged 1 commit intoMay 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mhdawson
approved these changes
May 1, 2025
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lpinca
approved these changes
May 2, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
FWIW, the default value is only 1 for OpenSSL < 3.2. On systems that compile and link against OpenSSL >= 3.2, the default value is already 2. That being said, I assume BoringSSL is still targeting OpenSSL 1.0.2/1.1.0/1.1.1 instead of 3.x, so assuming the pre-3.2 default seems reasonable. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 7, 2025
RafaelGSS
approved these changes
May 7, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Copy link
Copy Markdown
Contributor
|
This does not land cleanly on v22.x-staging |
Sorry, something went wrong.
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 25, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 25, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 25, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 26, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
anonrig
pushed a commit
to nodejs/ncrypto
that referenced
this pull request
Sep 26, 2025
PR-URL: nodejs/node#58103 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPENSSL_TLS_SECURITY_LEVEL isn't defined at all in BoringSSL and will cause compilation failures.
Ref #57323
Ref #56601
See boringssl search results