FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: remove unused functions and add todos by anonrig · Pull Request #58143 · nodejs/node · GitHub

/ node Public

http: remove unused functions and add todos - #58143

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/work-on-http-parser
May 9, 2025
ConversationCommits (1)ChecksFiles changed
Merged

http: remove unused functions and add todos#58143
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/work-on-http-parser

Conversation

anonrig commented May 3, 2025

Copy link
Copy Markdown
Member

I've added TODOs to all functions that can be added a v8 fast api.

anonrig requested review from jasnell, mcollina and ronag May 3, 2025 16:59

nodejs-github-bot commented May 3, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels May 3, 2025
mcollina approved these changes May 3, 2025
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 3, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2025

nodejs-github-bot commented May 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66569/

codecov Bot commented May 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (723d7bb) to head (12b0a63).
Report is 53 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58143   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files         630      630           
  Lines      186473   186457   -16     
  Branches    36613    36609    -4     
=======================================
- Hits       168160   168159    -1     
+ Misses      11128    11117   -11     
+ Partials     7185     7181    -4
Files with missing lines Coverage Δ
src/node_http_parser.cc 84.26% <ø> (+1.23%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented May 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66597/

ShogunPanda approved these changes May 5, 2025
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@anonrig LGTM as well.
Do you have a link on how eventually is supposed to be done?

anonrig commented May 5, 2025

Copy link
Copy Markdown
Member Author

Do you have a link on how eventually is supposed to be done?

I haven't created any issue. I'm planning on adding them soon.

nodejs-github-bot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66618/

nodejs-github-bot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66626/

nodejs-github-bot commented May 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66634/

nodejs-github-bot commented May 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66665/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
nodejs-github-bot merged commit e46fb17 into nodejs:main May 9, 2025

nodejs-github-bot commented May 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in e46fb17

targos pushed a commit that referenced this pull request May 16, 2025
http: remove unused functions and add todos
7715722 
PR-URL: #58143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
github-actions Bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
http: remove unused functions and add todos
5298da0 
PR-URL: #58143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
github-actions Bot mentioned this pull request Jun 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
jasnell jasnell approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes
ronag Awaiting requested review from ronag

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL