test: reduce flakiness in test-heapdump-http2 - #58148
Merged
nodejs-github-bot merged 1 commit intoMay 5, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot.
joyeecheung
force-pushed
the
test-heapdump-http2
branch
from
7a4d8f4 to
7f080a3
Compare
May 3, 2025 21:30
juanarbol
approved these changes
May 3, 2025
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58148 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 630 630
Lines 186473 186473
Branches 36613 36610 -3
==========================================
- Hits 168160 168157 -3
+ Misses 11128 11118 -10
- Partials 7185 7198 +13 see 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
May 4, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 16, 2025
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot. PR-URL: #58148 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot. PR-URL: #58148 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot.
This doesn't seem to reproduce in the CI (the CI is seeing a timeout caused by the deadlock instead) but locally when I was trying to reproduce the deadlock with with tools/test.py -J --repeat=1000 pummel/test-heapdump-http2 using a shared library build on macOS, this failure comes up first instead of the deadlock because the uv_try_write done for writing the file finishes too fast & synchronously - maybe because it's already cached under repeated runs - destroying the stream pipe already before the snapshot is taken.