async_hooks: ensure AsyncLocalStore instances work isolated - #58149
Merged
nodejs-github-bot merged 3 commits intoMay 6, 2025
Merged
async_hooks: ensure AsyncLocalStore instances work isolated#58149nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame.
Flarna
commented
May 3, 2025
Comment thread
test/async-hooks/test-async-local-storage-gcable.js
Outdated
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58149 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.01%
==========================================
Files 630 630
Lines 186473 186507 +34
Branches 36612 36618 +6
==========================================
+ Hits 168169 168183 +14
- Misses 11116 11121 +5
- Partials 7188 7203 +15
... and 32 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
legendecas
reviewed
May 4, 2025
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you for spotting this! LGTM
Sorry, something went wrong.
Comment thread
test/parallel/test-async-local-storage-isolation.js
BridgeAR
reviewed
May 4, 2025
Comment thread
lib/internal/async_local_storage/async_context_frame.js
legendecas
approved these changes
May 5, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Qard
approved these changes
May 5, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame. PR-URL: #58149 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame. PR-URL: #58149 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
mcollina
pushed a commit
to mcollina/node
that referenced
this pull request
Dec 12, 2025
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame. PR-URL: nodejs#58149 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame.