crypto: merge CipherBase.initiv into constructor - #58166
Merged
nodejs-github-bot merged 1 commit intoMay 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Now that `CipherBase.init` has been removed, instances of the class are always initialized by a call to `initiv` immediately after the constructor has returned. Instead of calling into C++ twice from `createCipherBase`, pass all required arguments to the constructor and fully initialize the instance before the constructor returns.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
panva
approved these changes
May 4, 2025
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #58166 +/- ##
==========================================
- Coverage 90.17% 90.13% -0.05%
==========================================
Files 630 630
Lines 186503 186605 +102
Branches 36614 36630 +16
==========================================
+ Hits 168187 168204 +17
- Misses 11124 11185 +61
- Partials 7192 7216 +24
... and 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 6, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Now that `CipherBase.init` has been removed, instances of the class are always initialized by a call to `initiv` immediately after the constructor has returned. Instead of calling into C++ twice from `createCipherBase`, pass all required arguments to the constructor and fully initialize the instance before the constructor returns. PR-URL: #58166 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
This does not land cleanly on v22.x-staging, and would require manual backport if we want it there |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that CipherBase.init has been removed, instances of the class are always initialized by a call to initiv immediately after the constructor has returned. Instead of calling into C++ twice from createCipherBase, pass all required arguments to the constructor and fully initialize the instance before the constructor returns.