test: allow tmpDir.path to be modified - #58173
Merged
nodejs-github-bot merged 1 commit intoMay 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58173 +/- ##
==========================================
- Coverage 90.17% 90.14% -0.03%
==========================================
Files 630 630
Lines 186756 186756
Branches 36664 36648 -16
==========================================
- Hits 168399 168359 -40
- Misses 11179 11183 +4
- Partials 7178 7214 +36 see 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
May 5, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 7, 2025
Copy link
Copy Markdown
Member
Author
|
This PR is author ready, no? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It's been seven days, can this land? |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58173 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58173 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior was changed in 8e87299, which broke make test-npm, as it tries modifying the path used for tmpDir.