FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: add support for `URL` for `fs.glob`'s `cwd` option by aduh95 · Pull Request #58182 · nodejs/node · GitHub

/ node Public

fs: add support for URL for fs.glob's cwd option - #58182

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:glob-file-url
May 11, 2025
ConversationCommits (3)ChecksFiles changed
Merged

fs: add support for URL for fs.glob's cwd option#58182
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:glob-file-url

Conversation

aduh95 commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

For the sake of consistency, all the Node.js APIs that take a path also accept URL instances.

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 5, 2025
aduh95 added dont-land-on-v20.x fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. and removed fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 5, 2025
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 5, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025

nodejs-github-bot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66616/

codecov Bot commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (4bfcad1) to head (941fcea).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58182   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         630      630           
  Lines      186784   186785    +1     
  Branches    36653    36654    +1     
=======================================
+ Hits       168377   168379    +2     
- Misses      11205    11210    +5     
+ Partials     7202     7196    -6
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.98% <100.00%> (+0.01%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig reviewed May 5, 2025
View reviewed changes
Comment thread lib/internal/fs/glob.js Outdated

anonrig May 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: These additions make optimizations extremely hard. We should avoid adding them.

aduh95 May 5, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You're commenting on a deleted line, it's not very clear what you mean

anonrig May 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Adding a URL support to input field

aduh95 commented May 5, 2025
View reviewed changes
Comment thread doc/api/fs.md Outdated
Comment thread doc/api/fs.md Outdated
Comment thread doc/api/fs.md Outdated

nodejs-github-bot commented May 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66619/

LiviaMedeiros reviewed May 6, 2025
View reviewed changes
Comment thread test/parallel/test-fs-glob.mjs Outdated
LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented May 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66652/

nodejs-github-bot commented May 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66664/

nodejs-github-bot commented May 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66684/

nodejs-github-bot commented May 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66756/

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 11, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
nodejs-github-bot merged commit 3ad7362 into nodejs:main May 11, 2025

nodejs-github-bot commented May 11, 2025

Copy link
Copy Markdown
Collaborator

Landed in 3ad7362

aduh95 deleted the glob-file-url branch May 11, 2025 18:26
targos pushed a commit that referenced this pull request May 16, 2025
fs: add support for URL for fs.glob's cwd option
130c135 
PR-URL: #58182
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
github-actions Bot mentioned this pull request May 20, 2025
Merged
aduh95 added a commit that referenced this pull request Jun 10, 2025
fs: add support for URL for fs.glob's cwd option
5c36510 
PR-URL: #58182
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
github-actions Bot mentioned this pull request Jun 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig left review comments
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
jazelly jazelly approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL