[v20.x] permission: ignore internalModuleStat on module loading - #58185
Closed
RafaelGSS wants to merge 1 commit into
Closed
[v20.x] permission: ignore internalModuleStat on module loading#58185RafaelGSS wants to merge 1 commit into
RafaelGSS wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RafaelGSS
force-pushed
the
backport-55797-to-v20
branch
from
bc3caae to
2a206d3
Compare
May 5, 2025 19:42
RafaelGSS
force-pushed
the
backport-55797-to-v20
branch
from
2a206d3 to
994eb5d
Compare
May 5, 2025 19:45
juanarbol
approved these changes
May 5, 2025
juanarbol
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
RafaelGSS
force-pushed
the
backport-55797-to-v20
branch
from
994eb5d to
f5c7741
Compare
May 5, 2025 22:30
marco-ippolito
force-pushed
the
backport-55797-to-v20
branch
from
f5c7741 to
b07d444
Compare
June 3, 2025 13:32
marco-ippolito
force-pushed
the
v20.x-staging
branch
3 times, most recently
from
ed0cf8c to
2b3b2a0
Compare
June 11, 2025 07:21
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
2b3b2a0 to
b427ae4
Compare
June 14, 2025 06:41
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: nodejs#55797 Backport-PR-URL: nodejs#58185 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
backport-55797-to-v20
branch
from
b07d444 to
e8eaced
Compare
July 10, 2025 22:39
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - permission: ignore internalModuleStat on module loading ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/16306740577 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
approved these changes
Aug 14, 2025
marco-ippolito
pushed a commit
that referenced
this pull request
Aug 14, 2025
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Backport-PR-URL: #58185 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Aug 25, 2025
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Backport-PR-URL: #58185 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Aug 27, 2025
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Backport-PR-URL: #58185 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check.
Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where a attempt to load b, it will fails as it reads $pwd and no permission has been given to this path.
PR-URL: #55797
Backport-PR-URL: #58185
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Ulises Gascón ulisesgascongonzalez@gmail.com