FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix sourcemaps with ts module mocking by marco-ippolito · Pull Request #58193 · nodejs/node · GitHub

/ node Public

lib: fix sourcemaps with ts module mocking - #58193

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-sourcemaps
May 8, 2025
ConversationCommits (1)ChecksFiles changed
Merged

lib: fix sourcemaps with ts module mocking#58193
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-sourcemaps

Conversation

marco-ippolito commented May 6, 2025

Copy link
Copy Markdown
Member

Fixes: #58119

nodejs-github-bot commented May 6, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2025

codecov Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (7e24ebc) to head (b16d5b2).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58193      +/-   ##
==========================================
+ Coverage   90.14%   90.18%   +0.03%     
==========================================
  Files         630      630              
  Lines      186780   186789       +9     
  Branches    36654    36688      +34     
==========================================
+ Hits       168381   168458      +77     
+ Misses      11197    11125      -72     
- Partials     7202     7206       +4
Files with missing lines Coverage Δ
lib/internal/test_runner/coverage.js 73.84% <100.00%> (+9.12%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025

nodejs-github-bot commented May 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66649/

nodejs-github-bot commented May 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66650/

pmarchini added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2025
nodejs-github-bot merged commit 8ccfcb5 into nodejs:main May 8, 2025

nodejs-github-bot commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Landed in 8ccfcb5

This comment was marked as spam.

Sign in to view

targos pushed a commit that referenced this pull request May 16, 2025
lib: fix sourcemaps with ts module mocking
868e72e 
PR-URL: #58193
Fixes: #58119
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
github-actions Bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
lib: fix sourcemaps with ts module mocking
af7baef 
PR-URL: #58193
Fixes: #58119
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
github-actions Bot mentioned this pull request Jun 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
pmarchini pmarchini approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
jabari-max jabari-max left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report code coverage fails when using experimental mock feature

7 participants

Back | FazBrowse Home | New Git URL