Revert "buffer: move SlowBuffer to EOL" by panva · Pull Request #58211 · nodejs/node · GitHub

This reverts commit 647175e.

The API in question was runtime-deprecated (#55175) and EOLd (#58008 which i'm reverting here) in the same major release. The intended cycle is that it gets runtime-deprecated as a major, and then EOLd in another later major.

Despite best efforts to detect it in the EOL PR there is breakage in the jsonwebtoken > jws > jwa dependency chain (29-30M weekly downloads on jwa).

This PR reverts to the runtime-deprecation state that was pending release with 24.0.0, EOL shouldn't have landed yet.

https://openjs-foundation.slack.com/archives/C019MGJQ8RH/p1746596637445769

We would re-land the EOL and ship it with a future major release after this revert.

This reverts commit 647175e.

Review requested:

@nodejs/config
@nodejs/performance
@nodejs/tsc

CI: https://ci.nodejs.org/job/node-test-pull-request/66672/

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (b21574d) to head (e074ef1).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58211      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.02%     
==========================================
  Files         629      629              
  Lines      186628   186644      +16     
  Branches    36632    36621      -11     
==========================================
- Hits       168218   168210       -8     
+ Misses      11219    11214       -5     
- Partials     7191     7220      +29

Files with missing lines	Coverage Δ
lib/buffer.js	100.00% <100.00%> (ø)
src/node_options.cc	85.36% <ø> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fast-track has been requested by @panva. Please 👍 to approve.

@panva please use Resume build to avoid re-running already-green jobs

@panva please use Resume build to avoid re-running already-green jobs

I did two times already before and because node-test-commit-osx failed each time with no indication why (other than pointing to checks API) i suspect that's because there were duplicate jobs started (or resumed) by someone as the ones I resumed were already running.

node-test-commit-osx failed each time with no indication why

You can see it in the logs:

Build timed out (after 60 minutes). Marking the build as failed.
Build was aborted

Re-running the other jobs is not going to help, I'd be very surprised it has anything to do with duplicated jobs (or that not resuming would even help if duplicate jobs were an issue).

node-test-commit-osx failed each time with no indication why

You can see it in the logs:
Build timed out (after 60 minutes). Marking the build as failed.
Build was aborted
Re-running the other jobs is not going to help, I'd be very surprised it has anything to do with duplicated jobs (or that not resuming would even help if duplicate jobs were an issue).

https://ci.nodejs.org/job/node-test-commit-osx/64970/nodes=osx13-x64/console

14:48:49 All tests passed.
...
15:48:53 Build timed out (after 60 minutes). Marking the build as failed.
15:48:53 Build was aborted
...
15:49:03 POST BUILD TASK : SUCCESS
...
15:49:03 Recording test results
15:49:07 [Checks API] No suitable checks publisher found.
15:49:07 Collecting metadata...
15:49:07 Metadata collection done.
15:49:07 [Checks API] No suitable checks publisher found.
15:49:07 Notifying upstream projects of job completion
15:49:07 Finished: FAILURE

node-test-commit-osx failed each time with no indication why

You can see it in the logs:
Build timed out (after 60 minutes). Marking the build as failed.
Build was aborted
Re-running the other jobs is not going to help, I'd be very surprised it has anything to do with duplicated jobs (or that not resuming would even help if duplicate jobs were an issue).
https://ci.nodejs.org/job/node-test-commit-osx/64970/nodes=osx13-x64/console

14:48:49 All tests passed.
...
15:48:53 Build timed out (after 60 minutes). Marking the build as failed.
15:48:53 Build was aborted
...
15:49:03 POST BUILD TASK : SUCCESS
...
15:49:03 Recording test results
15:49:07 [Checks API] No suitable checks publisher found.
15:49:07 Collecting metadata...
15:49:07 Metadata collection done.
15:49:07 [Checks API] No suitable checks publisher found.
15:49:07 Notifying upstream projects of job completion
15:49:07 Finished: FAILURE

FWIW I think this macOS failure is nodejs/build#4072 where it's taking a very long time to correct file ownership on the ccache files post-build.

@richardlau yeah, it's stuck on that step again now.

CI: https://ci.nodejs.org/job/node-test-pull-request/66689/

CI: https://ci.nodejs.org/job/node-test-pull-request/66693/

Landed in da69d13

any intention on getting a patch release out there for this? it's broken pretty much everything we use, now we need to roll back to 23.

This reverts commit 0579e0e PR-URL: #58211 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @aduh95.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

Notable changes: buffer: * Revert "buffer: move SlowBuffer to EOL (Filip Skokan) #58211 PR-URL: #58226

jwt token has a dependency that breaks in node 25 nodejs/node#58211 Azure/azure-sdk-for-js#34243

jwt token has a dependency that breaks in node 25 node:slim will always point to the latest node version, which is currently 25 nodejs/node#58211 Azure/azure-sdk-for-js#34243

Revert "buffer: move SlowBuffer to EOL"

e074ef1

This reverts commit 647175e.

panva added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 7, 2025

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels May 7, 2025

marco-ippolito approved these changes May 7, 2025

View reviewed changes

alan-agius4 mentioned this pull request May 7, 2025

ci: enable e2e test runs on Node.js 24 angular/angular-cli#30261

Merged

panva mentioned this pull request May 7, 2025

Add to citgm: jsonwebtoken nodejs/citgm#1097

Open

panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2025

micksatana mentioned this pull request May 7, 2025

fix: Build and test node 24-alpine micksatana/docker-medusa#2

Merged

LiviaMedeiros approved these changes May 7, 2025

View reviewed changes

aduh95 approved these changes May 7, 2025

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 7, 2025

joyeecheung approved these changes May 7, 2025

View reviewed changes

panva added the fast-track PRs that do not need to wait for 48 hours to land. label May 7, 2025

This comment was marked as duplicate.

Sign in to view

juanarbol approved these changes May 7, 2025

View reviewed changes

jasnell added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label May 7, 2025

aduh95 removed the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label May 7, 2025

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025

nodejs-github-bot merged commit da69d13 into nodejs:main May 7, 2025

panva deleted the revert-58008 branch May 7, 2025 19:31

benibenj mentioned this pull request May 8, 2025

Support Node 24: Cannot read properties of undefined (buffer-equal-constant-time) microsoft/vscode-vsce#1139

Open

aduh95 added the notable-change PRs with changes that should be highlighted in changelogs. label May 8, 2025

github-actions Bot mentioned this pull request May 8, 2025

2025-05-08, Version 24.0.1 (Current) #58226

Merged

nodejs-github-bot added a commit that referenced this pull request May 8, 2025

2025-05-08, Version 24.0.1 (Current)

f7b92d7

Notable changes: buffer: * Revert "buffer: move SlowBuffer to EOL (Filip Skokan) #58211 PR-URL: #58226

aduh95 pushed a commit that referenced this pull request May 8, 2025

2025-05-08, Version 24.0.1 (Current)

b849ed3

Notable changes: buffer: * Revert "buffer: move SlowBuffer to EOL (Filip Skokan) #58211 PR-URL: #58226

tohhengxing added a commit to opengovsg/mockpass that referenced this pull request Oct 23, 2025

fix: pin container file to node 24

1387cff

jwt token has a dependency that breaks in node 25 nodejs/node#58211 Azure/azure-sdk-for-js#34243

tohhengxing mentioned this pull request Oct 23, 2025

fix: pin container file to node 24 opengovsg/mockpass#758

Merged

ybash-automat-it mentioned this pull request Jun 2, 2026

Update jsonwebtoken to 9.0.3 mikenicholson/passport-jwt#263

Closed

Revert "buffer: move SlowBuffer to EOL" by panva · Pull Request #58211 · nodejs/node · GitHub

Uh oh!

Uh oh!

Revert "buffer: move SlowBuffer to EOL" - #58211

Revert "buffer: move SlowBuffer to EOL"#58211nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom panva:revert-58008panva/node:revert-58008Copy head branch name to clipboard

Conversation

panva commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

codecov Bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 7, 2025

Uh oh!

aduh95 commented May 7, 2025

Uh oh!

panva commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented May 7, 2025

Uh oh!

panva commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

richardlau commented May 7, 2025

Uh oh!

panva commented May 7, 2025

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

nodejs-github-bot commented May 7, 2025

Uh oh!

jpike88 commented May 8, 2025

Uh oh!

github-actions Bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Revert "buffer: move SlowBuffer to EOL"#58211
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:revert-58008

panva commented May 7, 2025 •
edited
Loading

codecov Bot commented May 7, 2025 •
edited
Loading

panva commented May 7, 2025 •
edited
Loading

panva commented May 7, 2025 •
edited
Loading