test: deflake test-http2-client-socket-destroy - #58212
Merged
nodejs-github-bot merged 1 commit intoMay 9, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The socket can be destroyed by the other peer while data is still being written. Add a listener for the `'error'` event.
Copy link
Copy Markdown
Member
Author
|
This should fix https://ci.nodejs.org/job/node-test-commit-osx/64927/nodes=osx13-x64/testReport/junit/(root)/parallel/test_http2_client_socket_destroy/ ---
duration_ms: 202.502
exitcode: 1
severity: fail
stack: |-
node:events:485
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TCP.onStreamRead (node:internal/stream_base_commons:216:20)
Emitted 'error' event on ServerHttp2Stream instance at:
at emitErrorNT (node:internal/streams/destroy:170:8)
at emitErrorCloseNT (node:internal/streams/destroy:129:3)
at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
Node.js v24.0.0-pre
...
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58212 +/- ##
=======================================
Coverage 90.13% 90.14%
=======================================
Files 629 629
Lines 186628 186628
Branches 36632 36623 -9
=======================================
+ Hits 168218 168227 +9
+ Misses 11219 11207 -12
- Partials 7191 7194 +3 see 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14883893336 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
May 8, 2025
jakecastelli
approved these changes
May 9, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
The socket can be destroyed by the other peer while data is still being written. Add a listener for the `'error'` event. PR-URL: #58212 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
The socket can be destroyed by the other peer while data is still being written. Add a listener for the `'error'` event. PR-URL: #58212 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket can be destroyed by the other peer while data is still being written. Add a listener for the 'error' event.