Review requested:

• @nodejs/realm
• @nodejs/startup

@jazelly Any reason why this was closed? Would you like to pick it up again?

I got a couple of JS crash/OOM in GHA like https://github.com/nodejs/node/actions/runs/14944261967/job/41985588150?pr=58217

I was thinking maybe this cannot be backported without backporting #55453? Was closing this to give me more time to debug this.

I think these crashes are irrelevant to this change.

For this GHA failed build on windows

D:\a\node\node\deps\v8\include\v8-internal.h(1159,36): error C2607: static assertion failed [D:\a\node\node\libnode.vcxproj]
  (compiling source file '/src/node_messaging.cc')
  
D:\a\node\node\deps\v8\include\v8-internal.h(1180,37): error C7683: you cannot create a reference to 'void' [D:\a\node\node\libnode.vcxproj]
  (compiling source file '/src/node_messaging.cc')

I got it reproduced in my windows machine, and reverting #57578 fixed it.

It failed due to a major change that lives in v23 and after but not before, specifically this one.

The LocalVector was introduced before/in v22, but it was then stablized in v23 with that change. I don't think #57578 should be back ported to v22.

Not sure if we have v22.x-staging build periodically. cause I believe the v22.x staging won't build on windows successfully with that LocalVector change.

Not sure if we have v22.x-staging build periodically. cause I believe the v22.x staging won't build on windows successfully with that LocalVector change.

We have daily builds of v22.x-staging https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-v22.x-staging/
(Link won't work right now for most people as the Jenkins CI is restricted at the moment while we're preparing this week's security release.)

It looks like Windows builds have been failing since 7 May with e0a025a -- they were passing the day before with 3f5899f.

I got it reproduced in my windows machine, and reverting #57578 fixed it.

Sorry I put a wrong link before. I was talking about this back port commit from #57733

it looks like Windows builds have been failing since 7 May with e0a025a

#57733 was back ported to v22.x-staging 5 hours before that, so it could be the one that causing the failed build.

If the failure log on windows about the the static assertion, then I think we need to revert that back port.

D:\a\node\node\deps\v8\include\v8-internal.h(1159,36): error C2607: static assertion failed [D:\a\node\node\libnode.vcxproj]
  (compiling source file '/src/node_messaging.cc')
  
D:\a\node\node\deps\v8\include\v8-internal.h(1180,37): error C7683: you cannot create a reference to 'void' [D:\a\node\node\libnode.vcxproj]
  (compiling source file '/src/node_messaging.cc')

I can raise a separate revert PR to revert backport c408a7f. But I am not sure about the OOM on linux, which I guess are also failing the v22.x-staging build.

@jazelly thanks for investigating that, I'm able to confirm that c408a7f is the culprit:
https://ci.nodejs.org/job/node-test-commit-windows-fanned/70430/ passes and https://ci.nodejs.org/job/node-test-commit-windows-fanned/70436/ doesn't.

I've removed it from the staging branch

CI: https://ci.nodejs.org/job/node-test-pull-request/66864/

CI: https://ci.nodejs.org/job/node-test-pull-request/66870/

CI: https://ci.nodejs.org/job/node-test-pull-request/66908/

Landed in 6ea250e...a376d10