| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58235 +/- ##
==========================================
+ Coverage 90.14% 90.18% +0.04%
==========================================
Files 629 629
Lines 186634 186660 +26
Branches 36616 36658 +42
==========================================
+ Hits 168236 168347 +111
+ Misses 11204 11119 -85
Partials 7194 7194
... and 50 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
Note that linter is failing /cc @nodejs/platform-windows |
Sorry, something went wrong.
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14928236826 |
Sorry, something went wrong.
|
I think a more correct solution is to avoid inlining this in the class body? Lines 130 to 132 in e74e065 Otherwise, node_builtins.h needs to include node_threadsafe_cow-inl.h to have the implementation of the read method. |
Sorry, something went wrong.
|
Closing this one since the other PR landed. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes a linker error when building Node.js with ClangCL due to missing explicit template instantiation for ThreadsafeCopyOnWrite<std::map<std::string, UnionBytes>>.
Fixes: #58208