FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: add missing typings for `TypedArray` by jazelly · Pull Request #58248 · nodejs/node · GitHub

/ node Public

typings: add missing typings for TypedArray - #58248

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:add-typed-array-types
May 12, 2025
Merged

typings: add missing typings for TypedArray#58248
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jazelly:add-typed-array-types

Conversation

jazelly commented May 9, 2025
edited
Loading

Copy link
Copy Markdown
Member

Add missing typings for the TypedArray domain we used in the codebase.

This enables typing intellisense for typed array. e.g.

const buffer = Buffer.allocUnsafe(length); // FastBuffer extends Uint8Array
TypedArrayPrototypeFill(buffer, 0, pos, length);

will be evaluated to

const TypedArrayPrototypeFill: <FastBuffer>(self: FastBuffer, value: number, start?: number, end?: number) => FastBuffer

jazelly changed the title typings: add typings for TypedArray typings: add missing typings for TypedArray May 9, 2025
jazelly force-pushed the add-typed-array-types branch from 9ddbb55 to 8a59bae Compare May 9, 2025 14:02
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 9, 2025
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
nodejs-github-bot merged commit 5b134db into nodejs:main May 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in 5b134db

targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
PR-URL: #58248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL