sqlite: set name and length on sqlite.backup() - #58251
Merged
nodejs-github-bot merged 1 commit intoMay 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
cjihrig
approved these changes
May 9, 2025
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a minor nit. Thanks!
Sorry, something went wrong.
Comment thread
src/node_sqlite.cc
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think we already have backup_string that can be used here.
Sorry, something went wrong.
LiviaMedeiros
force-pushed
the
sqlite-backup-props
branch
from
1bb0b66 to
cc251a3
Compare
May 9, 2025 16:27
geeksilva97
approved these changes
May 9, 2025
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - sqlite: set `name` and `length` on `sqlite.backup()` ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14933373676 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #58251 +/- ##
==========================================
+ Coverage 90.12% 90.18% +0.05%
==========================================
Files 629 629
Lines 186638 186659 +21
Branches 36618 36654 +36
==========================================
+ Hits 168202 168331 +129
+ Misses 11222 11123 -99
+ Partials 7214 7205 -9
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
benjamingr
approved these changes
May 9, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.