tools: ignore deps and benchmark folder - #58254
Merged
aduh95 merged 1 commit intoMay 15, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
benjamingr
approved these changes
May 10, 2025
Copy link
Copy Markdown
Contributor
|
It'd be less confusing to amend the commit message to say it's CodeQL related |
Sorry, something went wrong.
lpinca
approved these changes
May 10, 2025
jasnell
approved these changes
May 12, 2025
bjohansebas
approved these changes
May 15, 2025
bjohansebas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58254 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58254 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve nodejs/security-wg#1453 (comment)
cc: @nodejs/security-wg