FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

worker: update code examples for `node:worker_threads` module by fisker · Pull Request #58264 · nodejs/node · GitHub

/ node Public

worker: update code examples for node:worker_threads module - #58264

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
fisker:worker-docs
Jan 5, 2026
Merged

worker: update code examples for node:worker_threads module#58264
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
fisker:worker-docs

Conversation

fisker commented May 10, 2025
edited
Loading

Copy link
Copy Markdown
Contributor
  • Missed one import.
  • Use .once for one time events.
  • Use node:assert/strict instead of node:assert.

nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels May 10, 2025
Comment thread doc/api/worker_threads.md Outdated

```mjs
import assert from 'node:assert';
import assert from 'node:assert/strict';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The rest of the changes here are ok but this one is generally unnecessary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Comment thread doc/api/worker_threads.md Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 5, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2026
nodejs-github-bot merged commit 01e44dc into nodejs:main Jan 5, 2026
27 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 01e44dc

fisker deleted the worker-docs branch January 5, 2026 16:04
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 15, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 19, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 mentioned this pull request Feb 22, 2026
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
PR-URL: #58264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL