doc: update commit-queue documentation - #58275
Merged
nodejs-github-bot merged 1 commit intoMay 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
dario-piotrowicz
force-pushed
the
dario/doc/commit-queue-stable
branch
from
de97f6f to
7112fb9
Compare
May 11, 2025 12:05
Comment thread
.github/workflows/commit-queue.yml
Outdated
Comment thread
doc/contributing/commit-queue.md
Outdated
dario-piotrowicz
force-pushed
the
dario/doc/commit-queue-stable
branch
2 times, most recently
from
dea0b02 to
f672e6d
Compare
May 11, 2025 15:02
update the commit-queue contributing documentation by: - removing the references of the feature being experimental - clarifying that it applies to mergeable pull requests
dario-piotrowicz
force-pushed
the
dario/doc/commit-queue-stable
branch
from
f672e6d to
9978e7a
Compare
May 11, 2025 15:04
bjohansebas
approved these changes
May 11, 2025
jasnell
approved these changes
May 12, 2025
aduh95
approved these changes
May 12, 2025
UlisesGascon
approved these changes
May 12, 2025
richardlau
approved these changes
May 12, 2025
mhdawson
approved these changes
May 12, 2025
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mcollina
approved these changes
May 13, 2025
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
legendecas
approved these changes
May 13, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
update the commit-queue contributing documentation by: - removing the references of the feature being experimental - clarifying that it applies to mergeable pull requests PR-URL: #58275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
update the commit-queue contributing documentation by: - removing the references of the feature being experimental - clarifying that it applies to mergeable pull requests PR-URL: #58275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the commit-queue contributing documentation by:
Note
I'm proposing to remove the references of the feature being experimental since it's been
implemented 5 years ago and I think that it's widely used, so I think that it can be considered
stable at this point