test: remove unnecessary console.log from test-repl-null-thrown - #58281
Merged
nodejs-github-bot merged 1 commit intoMay 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dario-piotrowicz
force-pushed
the
dario/test-repl-null-thrown-consolelog
branch
from
e535769 to
f653cc2
Compare
May 11, 2025 17:29
cjihrig
approved these changes
May 11, 2025
pmarchini
approved these changes
May 11, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58281 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.01%
==========================================
Files 631 631
Lines 186687 186689 +2
Branches 36663 36669 +6
==========================================
- Hits 168355 168350 -5
+ Misses 11124 11120 -4
- Partials 7208 7219 +11 see 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
bjohansebas
approved these changes
May 12, 2025
jasnell
approved these changes
May 12, 2025
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58281 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58281 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super minor, but I noticed this rouge console.log and figured that we might just as well get rid of it 🙂