doc: fix CryptoKey.algorithm type and other interfaces in webcrypto.md - #58294
Merged
nodejs-github-bot merged 2 commits intoMay 14, 2025
Merged
doc: fix CryptoKey.algorithm type and other interfaces in webcrypto.md#58294nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
flakey5
approved these changes
May 12, 2025
lpinca
approved these changes
May 12, 2025
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
flakey5
added a commit
to nodejs/doc-kit
that referenced
this pull request
May 12, 2025
Mirrors changes in nodejs/node#58294 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> Co-authored-by: Filip Skokan <panva.ip@gmail.com>
ovflowd
approved these changes
May 12, 2025
jasnell
approved these changes
May 12, 2025
panva
commented
May 13, 2025
Comment thread
tools/doc/type-parser.mjs
Outdated
anonrig
approved these changes
May 14, 2025
flakey5
added a commit
to nodejs/doc-kit
that referenced
this pull request
May 15, 2025
* fix: CryptoKey.algorithm type and other interfaces Mirrors changes in nodejs/node#58294 Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> Co-authored-by: Filip Skokan <panva.ip@gmail.com> * Update src/utils/parser/constants.mjs Co-authored-by: Filip Skokan <panva.ip@gmail.com> --------- Co-authored-by: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58294 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58294 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #57376
Reminder: the classes referred to in webcrypto.md docs are mere WebIDL interfaces/dictionaries taken from the Web Cryptography API spec, apart from CryptoKey these are not actual classes.