Review requested:

• @nodejs/streams
• @nodejs/test_runner

Relevant to advancing on this: #58526

I'm ok with the addition. I'm a bit worried about the potential change in behavior, as I didn't have time to explore yet if there is a change in the order of operations.

What change in behavior are you concerned about? This should not change any existing behavior of the EventEmitter

I've updated the implementation to rename the use method to a single addDisposableListener method with a once option. It returns a dispose function that has the Symbol.dispose property attached to call itself. PTAL

Is there any way we can avoid adding yet another way to register events? i.e. can this be an option and not a method?

I think this was blocked previously in AbortSignal due to a V8 optimization that happened since.

Is there any way we can avoid adding yet another way to register events? i.e. can this be an option and not a method?

Not without adding too much complexity. As it is now, addListener(...) returns the EventEmitter itself. Adding an option would mean making the return value polymorphic which is far worse than adding a new separate API. See the discussion around #58526

Regarding the single-use disposable that's just a disposer, with no associated object data: is

function dispose() { ... }
dispose[SymbolDispose] = dispose
return dispose

OK, or should we be keeping things consistent with the draft guidance for disposers in general?

function dispose() { ... }
return {
  dispose,
  [SymbolDispose]: dispose,
  // or
  [SymbolDispose]() { dispose() },
}

My vote would be for the latter – it would be an inconsistent pattern for disposables to sometimes be directly callable, and other times not.

CI: https://ci.nodejs.org/job/node-test-pull-request/67322/ 💛

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (3c351c2) to head (f4ca9ae).
Report is 142 commits behind head on main.

@@            Coverage Diff             @@
##             main   #58453      +/-   ##
==========================================
+ Coverage   90.13%   90.14%   +0.01%     
==========================================
  Files         636      636              
  Lines      187891   187932      +41     
  Branches    36878    36883       +5     
==========================================
+ Hits       169348   169408      +60     
- Misses      11289    11290       +1     
+ Partials     7254     7234      -20     

... and 34 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs/tsc ... I'd still like some opinions on whether y'all think this is a good idea or not.

Closing given lack of responses to pings. Would appears there's not much interest in this