src: make global error message vectors const in contextify - #58580
Merged
nodejs-github-bot merged 1 commit intoJun 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mertcanaltin
force-pushed
the
mert/refactor/contextify-memory-safety-perf
branch
from
fd41107 to
71dd334
Compare
June 4, 2025 21:38
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58580 +/- ##
==========================================
- Coverage 90.21% 90.20% -0.02%
==========================================
Files 635 635
Lines 187494 187511 +17
Branches 36838 36815 -23
==========================================
- Hits 169144 169140 -4
- Misses 11145 11171 +26
+ Partials 7205 7200 -5
... and 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Jun 5, 2025
legendecas
approved these changes
Jun 5, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Jun 5, 2025
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These could even be std::array, right?
Sorry, something went wrong.
Comment thread
src/node_contextify.cc
Outdated
addaleax
approved these changes
Jun 5, 2025
Comment thread
src/node_contextify.cc
Outdated
mertcanaltin
force-pushed
the
mert/refactor/contextify-memory-safety-perf
branch
5 times, most recently
from
19a716c to
7be95fa
Compare
June 5, 2025 23:43
mertcanaltin
force-pushed
the
mert/refactor/contextify-memory-safety-perf
branch
from
7be95fa to
faf8ce9
Compare
June 5, 2025 23:45
addaleax
approved these changes
Jun 6, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
PR-URL: nodejs#58580 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58580 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58580 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58580 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I converted esm_syntax_error_messages and throws_only_in_cjs_error_messages to const vector