doc: add path rules and validation for export targets in package.json - #58604
Merged
nodejs-github-bot merged 1 commit intoJun 9, 2025
Merged
doc: add path rules and validation for export targets in package.json#58604nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
algoORgoal
reviewed
Jun 7, 2025
algoORgoal
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
This commit describes what was missing perfectly. Thank you for your pull request :)
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Jun 7, 2025
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for this!
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Jun 7, 2025
marco-ippolito
approved these changes
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
reviewed
Jun 7, 2025
Comment thread
doc/api/packages.md
Outdated
aduh95
approved these changes
Jun 9, 2025
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
PR-URL: nodejs#58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #58576
I have added a new section called # Path Rules and Validation for Export Targets that goes over the invalid paths that are possible & and their valid counter parts