FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add new CopyUtimes function to reduce code duplication by dario-piotrowicz · Pull Request #58625 · nodejs/node · GitHub

/ node Public

src: add new CopyUtimes function to reduce code duplication - #58625

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/node_file_CopyUtimes
Jun 9, 2025
Merged

src: add new CopyUtimes function to reduce code duplication#58625
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/node_file_CopyUtimes

Conversation

Copy link
Copy Markdown
Member

No description provided.

dario-piotrowicz requested a review from anonrig June 7, 2025 23:26
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 7, 2025

codecov Bot commented Jun 8, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (3c351c2) to head (0208df9).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 60.00% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58625      +/-   ##
==========================================
+ Coverage   90.13%   90.16%   +0.03%     
==========================================
  Files         636      636              
  Lines      187891   187881      -10     
  Branches    36878    36872       -6     
==========================================
+ Hits       169348   169402      +54     
+ Misses      11289    11235      -54     
+ Partials     7254     7244      -10     
Files with missing lines Coverage Δ
src/node_file.cc 75.93% <60.00%> (+0.33%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jun 8, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025

Copy link
Copy Markdown
Collaborator

dario-piotrowicz added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2025
nodejs-github-bot merged commit bce60ab into nodejs:main Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in bce60ab

dario-piotrowicz deleted the dario/node_file_CopyUtimes branch June 10, 2025 09:02
seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
PR-URL: nodejs#58625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Jun 16, 2025
PR-URL: #58625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
PR-URL: #58625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
PR-URL: #58625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL