FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: improve release proposal linter by aduh95 · Pull Request #58647 · nodejs/node · GitHub

/ node Public

tools: improve release proposal linter - #58647

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:improve-release-proposal-linter
Jun 11, 2025
Merged

tools: improve release proposal linter#58647
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:improve-release-proposal-linter

Conversation

aduh95 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor
  • Add an annotation on the line that's causing the linter to fail (if applicable)
  • Do not exit the program on the first error (in case there are several errors)
  • Improve some error messages

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 9, 2025
aduh95 requested a review from a team June 10, 2025 13:05

marco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if tested

aduh95 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

I did test it with https://github.com/nodejs/node/actions/runs/15537367744

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 10, 2025
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2025
nodejs-github-bot merged commit 3a7f8ef into nodejs:main Jun 11, 2025

Copy link
Copy Markdown
Collaborator

Landed in 3a7f8ef

targos pushed a commit that referenced this pull request Jun 16, 2025
PR-URL: #58647
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95 added a commit that referenced this pull request Jul 21, 2025
PR-URL: #58647
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
aduh95 added a commit that referenced this pull request Jul 24, 2025
PR-URL: #58647
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL