FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: avoid deprecated `require.extensions` in tab completion by gulbaki · Pull Request #58653 · nodejs/node · GitHub

/ node Public

repl: avoid deprecated require.extensions in tab completion - #58653

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
gulbaki:repl-no-require-extensions
Jun 23, 2025
ConversationCommits (3)ChecksFiles changed
Merged

repl: avoid deprecated require.extensions in tab completion#58653
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
gulbaki:repl-no-require-extensions

Conversation

gulbaki commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

This PR replaces the usage of require.extensions in the REPL autocompletion logic with Module._extensions.

require.extensions has been runtime-deprecated under DEP0039, and its usage triggers a warning in recent Node.js versions. Since require.extensions is just a user-land alias for Module._extensions, we can safely access the same object via Module._extensions without any behavioral change or deprecation warning.

Changes:

  • this.context.require.extensions → Module._extensions in the REPL complete() function
  • Adds an inline comment explaining the deprecation and replacement
  • No functional behavior change

Fixes: #58641

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jun 9, 2025
dario-piotrowicz reviewed Jun 9, 2025
View reviewed changes

dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very nice, thanks for the PR @gulbaki 😃🙏

I've left a couple of small comments

Comment thread lib/repl.js Outdated
Ethan-Arrowood requested changes Jun 10, 2025
View reviewed changes

Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you also include a test for this? Here is an example of how I tested process warnings: https://github.com/nodejs/node/blob/main/test/parallel/test-process-warnings.mjs

Comment thread lib/repl.js Outdated
// `require.extensions` is runtime-deprecated (DEP0039).
// Use `Module._extensions` to access the same extension map
// without triggering the deprecation warning.
const Module = require('module');

Ethan-Arrowood Jun 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Consider moving this to the top of the file.

marco-ippolito commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Could you also include a test for this? Here is an example of how I tested process warnings: https://github.com/nodejs/node/blob/main/test/parallel/test-process-warnings.mjs

It's not runtime deprecated (doc only) so it's not possible to capture the experimental warning

dario-piotrowicz approved these changes Jun 10, 2025
View reviewed changes

dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 🙂

Ethan-Arrowood requested changes Jun 10, 2025
View reviewed changes
Comment thread lib/repl.js Outdated
gulbaki requested a review from Ethan-Arrowood June 11, 2025 10:45

codecov Bot commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (905a722) to head (5cb5079).
Report is 71 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58653      +/-   ##
==========================================
- Coverage   90.15%   90.14%   -0.01%     
==========================================
  Files         636      636              
  Lines      188040   188057      +17     
  Branches    36903    36895       -8     
==========================================
- Hits       169535   169532       -3     
- Misses      11239    11278      +39     
+ Partials     7266     7247      -19
Files with missing lines Coverage Δ
lib/repl.js 95.13% <100.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2025

nodejs-github-bot commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67409/

juanarbol added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 13, 2025
marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2025
nodejs-github-bot merged commit dcfdaab into nodejs:main Jun 23, 2025

nodejs-github-bot commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

Landed in dcfdaab

RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
repl: avoid deprecated require.extensions in tab completion
d0e42ff 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
repl: avoid deprecated require.extensions in tab completion
0780856 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
repl: avoid deprecated require.extensions in tab completion
9ef1cd1 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
repl: avoid deprecated require.extensions in tab completion
28f9f92 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
repl: avoid deprecated require.extensions in tab completion
1f0d719 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
repl: avoid deprecated require.extensions in tab completion
6457583 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
repl: avoid deprecated require.extensions in tab completion
1a28311 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
repl: avoid deprecated require.extensions in tab completion
2d96e31 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
repl: avoid deprecated require.extensions in tab completion
6ed16a8 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
repl: avoid deprecated require.extensions in tab completion
9b2edb7 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
repl: avoid deprecated require.extensions in tab completion
f891ae3 
PR-URL: #58653
Fixes: #58641
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller left review comments
lpinca lpinca approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes
juanarbol juanarbol approved these changes
marco-ippolito marco-ippolito approved these changes
dario-piotrowicz dario-piotrowicz approved these changes
puskin Awaiting requested review from puskin
BridgeAR Awaiting requested review from BridgeAR
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repl: don't rely on require.extensions

9 participants

Back | FazBrowse Home | New Git URL