module: fix typescript import.meta.main - #58661
Merged
nodejs-github-bot merged 1 commit intoJun 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58661 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 636 636
Lines 188030 188028 -2
Branches 36894 36892 -2
==========================================
- Hits 169563 169538 -25
- Misses 11214 11232 +18
- Partials 7253 7258 +5
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
meixg
approved these changes
Jun 10, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Jun 10, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Jun 10, 2025
Ethan-Arrowood
approved these changes
Jun 10, 2025
pmarchini
approved these changes
Jun 11, 2025
atlowChemi
approved these changes
Jun 11, 2025
anonrig
approved these changes
Jun 12, 2025
Lordfirespeed
pushed a commit
to Lordfirespeed/node
that referenced
this pull request
Jun 13, 2025
PR-URL: nodejs#58661 Fixes: nodejs#58660 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> (cherry picked from commit bba07d7)
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58661 Fixes: #58660 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Jun 23, 2025
aduh95
pushed a commit
to Lordfirespeed/node
that referenced
this pull request
Jul 28, 2025
PR-URL: nodejs#58661 Backport-PR-URL: nodejs#58693 Fixes: nodejs#58660 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #58660