FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: edit commit-queue workflow file by aduh95 · Pull Request #58667 · nodejs/node · GitHub

/ node Public

tools: edit commit-queue workflow file - #58667

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:cq-shallow-fetch
Jun 12, 2025
Merged

tools: edit commit-queue workflow file#58667
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:cq-shallow-fetch

Conversation

aduh95 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

With nodejs/node-core-utils#918, we no longer need to preemptively fetch the full history. There are also a bunch of nits to make the code more consistent with the rest of the code base.

Tested with https://github.com/nodejs/node-auto-test/actions/runs/15568681251

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 10, 2025

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

LiviaMedeiros added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 11, 2025
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
nodejs-github-bot merged commit efd28a0 into nodejs:main Jun 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in efd28a0

aduh95 deleted the cq-shallow-fetch branch June 12, 2025 21:41
targos pushed a commit that referenced this pull request Jun 16, 2025
PR-URL: #58667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit that referenced this pull request Jul 21, 2025
PR-URL: #58667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 added a commit that referenced this pull request Jul 24, 2025
PR-URL: #58667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL