src: enhance error messages for unknown options - #58677
Merged
nodejs-github-bot merged 1 commit intoJun 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
approved these changes
Jun 11, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #58677 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 636 636
Lines 188028 188060 +32
Branches 36895 36903 +8
=======================================
+ Hits 169547 169576 +29
- Misses 11233 11236 +3
Partials 7248 7248
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jun 11, 2025
RaisinTen
approved these changes
Jun 12, 2025
addaleax
approved these changes
Jun 12, 2025
jasnell
approved these changes
Jun 12, 2025
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58677 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jun 23, 2025
Copy link
Copy Markdown
Contributor
|
This doesn't land cleanly on v22.x-staging |
Sorry, something went wrong.
geeksilva97
pushed a commit
to geeksilva97/node
that referenced
this pull request
Sep 20, 2025
PR-URL: nodejs#58677 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the error was being printed in a malformed way, containing part of the JSON content