doc: update "Spawning .bat and .cmd files on Windows" section - #58739
Closed
ericcornelissen wants to merge 1 commit into
Closed
doc: update "Spawning .bat and .cmd files on Windows" section#58739ericcornelissen wants to merge 1 commit into
ericcornelissen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Remove the suggestion to use `spawn` following DEP0190. Fixes: #58735 Refs: https://nodejs.org/docs/latest-v24.x/api/child_process.html
Copy link
Copy Markdown
Member
|
Humble ping to @nodejs/documentation |
Sorry, something went wrong.
Knagis
reviewed
Jun 25, 2025
Comment thread
doc/api/child_process.md
| }); | ||
|
|
||
| // Script with spaces in the filename: | ||
| const bat = spawn('"my script.cmd" a b', { shell: true }); |
Copy link
Copy Markdown
There was a problem hiding this comment.
this doesn't use args array, so this doesn't fall into the DEP0190 case
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
You're right! I hadn't noticed that.
In that case I agree this may be rejected. Still, depending on the intention of DEP0190, I think it could make some sense to remove this example. Hence, I'll leave it up to the maintainers to close or merge this depending on their opinion. (Notwithstanding your earlier comment about the stdio option.)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the suggestion to use spawn following DEP0190.
Fixes: #58735
Refs: https://nodejs.org/docs/latest-v24.x/api/child_process.html