lib: remove globalPreload support - #58743
Open
kazuma0129 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Since the loader is now stable, the warning when using globalPreload is no longer necessary.
The globalPreload warning is no longer emitted, so the related test is removed.
kazuma0129
force-pushed
the
kazuma0129-patch-1
branch
from
970c7e7 to
f777eab
Compare
June 17, 2025 16:44
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #58743 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.04%
==========================================
Files 639 639
Lines 188201 188185 -16
Branches 36915 36914 -1
==========================================
- Hits 169675 169601 -74
- Misses 11274 11316 +42
- Partials 7252 7268 +16
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Jun 17, 2025
mcollina
approved these changes
Jun 18, 2025
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Jun 18, 2025
JakobJingleheimer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Loaders aren't stable, but I think it's been enough time to remove.
In an abundance of caution though, perhaps let's mark this major?
Sorry, something went wrong.
Ethan-Arrowood
approved these changes
Jun 18, 2025
jasnell
approved these changes
Jun 20, 2025
Copy link
Copy Markdown
Contributor
|
This pull request has been marked as stale due to 210 days of inactivity. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/58743 ✔ Done loading data for nodejs/node/pull/58743 ----------------------------------- PR info ------------------------------------ Title lib: remove globalPreload support (#58743) Author Kazuma Ohashi <kazuma0129.work@gmail.com> (@kazuma0129, first-time contributor) Branch kazuma0129:kazuma0129-patch-1 -> nodejs:main Labels semver-major, esm, needs-ci, stale Commits 2 - lib: remove globalPreload support - test: remove deprecated globalPreload tests Committers 1 - KazumaOhashi <kazuma0129.work@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58743 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58743 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 17 Jun 2025 16:36:38 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58743#pullrequestreview-2936990929 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58743#pullrequestreview-2937852337 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/58743#pullrequestreview-2937948049 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58743#pullrequestreview-2940141301 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58743#pullrequestreview-2946915441 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-18T06:21:09Z: https://ci.nodejs.org/job/node-test-pull-request/67511/ - Querying data for job/node-test-pull-request/67511/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/24637140337 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Can you rebase to fix the conflict? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved TODO left at #49144.