test: correct SIMD support comment - #58767
Merged
nodejs-github-bot merged 1 commit intoJun 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The comment in the test file stated that: "SIMD is not supported on rhel8-ppc64le" This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture.
Ethan-Arrowood
approved these changes
Jun 19, 2025
targos
approved these changes
Jun 19, 2025
juanarbol
approved these changes
Jun 19, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58767 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 639 639
Lines 188192 188192
Branches 36911 36912 +1
=======================================
+ Hits 169634 169635 +1
- Misses 11287 11289 +2
+ Partials 7271 7268 -3 see 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Jun 19, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RaisinTen
approved these changes
Jun 20, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
The comment in the test file stated that: "SIMD is not supported on rhel8-ppc64le" This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture. PR-URL: #58767 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
The comment in the test file stated that: "SIMD is not supported on rhel8-ppc64le" This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture. PR-URL: #58767 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
The comment in the test file stated that: "SIMD is not supported on rhel8-ppc64le" This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture. PR-URL: #58767 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment in the test file stated that:
"SIMD is not supported on rhel8-ppc64le"
This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture.
Currently in our CI, it just so happens that all of our rhel8-ppc64le machines are IBM Power8, while, for example, the rhel9-ppc64le machines were provisioned as IBM Power9, but AFAIK you could be running either RHEL 8/9 on either architecture (or newer).
FTR other (non-IBM) "older architectures" without WASM SIMD support include some Athlon chips (but we don't have any of those in our CI): nodejs/undici#2934 (comment)