FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x] tools: disable failing coverage jobs by aduh95 · Pull Request #58770 · nodejs/node · GitHub

/ node Public

[v22.x] tools: disable failing coverage jobs - #58770

Merged
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
aduh95:skip-coverage-jobs
Jun 23, 2025
Merged

[v22.x] tools: disable failing coverage jobs#58770
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
aduh95:skip-coverage-jobs

Conversation

aduh95 commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Those have been failing for a while, and no one has managed to find out how to fix it. Keeping a failing job that we ignore the result is really not healthy, and just wasteful at this point, let's disable it.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

aduh95 changed the title tools: disable failing coverage jobs [v22.x] tools: disable failing coverage jobs Jun 20, 2025
nodejs-github-bot added meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jun 20, 2025
aduh95 requested a review from a team June 20, 2025 07:16
aduh95 force-pushed the skip-coverage-jobs branch from ce08a5e to 27fc963 Compare June 20, 2025 07:35

Copy link
Copy Markdown
Member

We probably should backport this to v20

PR-URL: nodejs#58770
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 force-pushed the skip-coverage-jobs branch from 27fc963 to b7feda9 Compare June 23, 2025 10:16

aduh95 commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Landed in b7feda9

aduh95 merged commit b7feda9 into nodejs:v22.x-staging Jun 23, 2025
aduh95 deleted the skip-coverage-jobs branch June 23, 2025 10:17
aduh95 added a commit that referenced this pull request Jun 23, 2025
PR-URL: #58770
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
PR-URL: #58770
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL