test_runner: automatically wait for subtests to finish - #58800
Closed
LiviaMedeiros wants to merge 1 commit into
Closed
test_runner: automatically wait for subtests to finish#58800LiviaMedeiros wants to merge 1 commit into
LiviaMedeiros wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This commit updates the test runner to automatically wait for subtests to finish. This makes the experience more consistent with suites and removes the need to await anything.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #58800 +/- ##
=======================================
Coverage 90.07% 90.08%
=======================================
Files 640 640
Lines 188262 188286 +24
Branches 36912 36915 +3
=======================================
+ Hits 169580 169612 +32
+ Misses 11399 11396 -3
+ Partials 7283 7278 -5
... and 37 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jun 24, 2025
pmarchini
approved these changes
Jun 24, 2025
RafaelGSS
approved these changes
Jun 24, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 24, 2025
This commit updates the test runner to automatically wait for subtests to finish. This makes the experience more consistent with suites and removes the need to await anything. PR-URL: #58800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 24, 2025
This commit updates the test runner to automatically wait for subtests to finish. This makes the experience more consistent with suites and removes the need to await anything. PR-URL: #58800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #56664 (aa3523e) which was reverted in #58282 due to breakage caused by other parts of it.
Authorship belongs to @cjihrig.
To minimize problems in userland, it would be highly preferable to ship this in the same release as #58282 (7a0c74b in particular), since aa3523e was already shipped in v24.0.0 and releasing this PR would keep everything as-is for current v24.x users.
This should not land on previous major release lines because #56664 was semver-major PRs that contain breaking changes and should be released in the next major version. (although IMHO this particular change is backportable)
Cherry-pick was not 100% clean, there was a trivial conflict with #56765 at the end of lib/internal/test_runner/test.js diff, cc @pmarchini just in case.
cc @cjihrig @romainmenke @nodejs/test_runner