FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add missing environment variables to manpage and remove test wor… by HumaneLogic · Pull Request #58924 · nodejs/node · GitHub

/ node Public

doc: add missing environment variables to manpage and remove test wor… - #58924

Closed
HumaneLogic wants to merge 7 commits into
nodejs:mainfrom
HumaneLogic:main
ConversationCommits (7)ChecksFiles changed
Closed

doc: add missing environment variables to manpage and remove test wor…#58924
HumaneLogic wants to merge 7 commits into
nodejs:mainfrom
HumaneLogic:main

Conversation

HumaneLogic commented Jul 1, 2025 •
edited by dario-piotrowicz
Loading

Copy link
Copy Markdown
Contributor

Fixes: #58894

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 1, 2025
HumaneLogic mentioned this pull request Jul 2, 2025
Closed
dario-piotrowicz reviewed Jul 2, 2025
View reviewed changes

dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you very much for the PR @HumaneLogic 🎉

I've left a few small comments but overall looks good to me 🙂

PS: the commit message needs to be shortened (as I mentioned in the issue)

Comment thread doc/node.1 Outdated
Comment thread doc/node.1 Outdated
Comment thread doc/node.1 Outdated
Comment thread doc/node.1 Outdated
Comment thread doc/node.1 Outdated
Comment thread doc/node.1 Outdated

codecov Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (a7a37c3) to head (1c46679).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58924      +/-   ##
==========================================
- Coverage   90.11%   90.10%   -0.01%     
==========================================
  Files         640      640              
  Lines      188427   188427              
  Branches    36956    36962       +6     
==========================================
- Hits       169792   169781      -11     
- Misses      11348    11349       +1     
- Partials     7287     7297      +10

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

HumaneLogic commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

im sorry it took too long ,i'm gonna fix them right now

dario-piotrowicz commented Jul 2, 2025

Copy link
Copy Markdown
Member

im sorry it took too long ,i'm gonna fix them right now

No problem there's no rush 🙂

The commit still needs to be fixed, could you please rebase, squash the two commits into one and update the commit message? 🙂

HumaneLogic commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

The commit still needs to be fixed, could you please rebase, squash the two commits into one and update the commit message?
yes i'll do it

doc: add missing environment variables to manpage and remove test wor…
5f7c9d0 
…karound

test: remove fallback for missing manpage env vars

test: remove fallback for missing manpage env vars
doc: add missing env vars and remove test fallback
d395dcb

HumaneLogic commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@dario-piotrowicz i made a new pull request, i had problems with squashing, i created a new PR #58963

dario-piotrowicz commented Jul 5, 2025

Copy link
Copy Markdown
Member

Closing as per the above comment

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dario-piotrowicz dario-piotrowicz left review comments

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some environment variables documented in the CLI docs are missing in node manpage

3 participants

Back | FazBrowse Home | New Git URL