FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move http proxy tests to test/client-proxy by joyeecheung · Pull Request #58950 · nodejs/node · GitHub

/ node Public

test: move http proxy tests to test/client-proxy - #58950

Closed
joyeecheung wants to merge 2 commits into
nodejs:mainfrom
joyeecheung:case-precedence
ConversationCommits (2)ChecksFiles changed
Closed

test: move http proxy tests to test/client-proxy#58950
joyeecheung wants to merge 2 commits into
nodejs:mainfrom
joyeecheung:case-precedence

Conversation

joyeecheung commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Move them to a separate directory for the ease of running them. And Rewrite to ESM to use TLA.
Also add a test to make sure case precedence is honored.
Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy

Split off from the WIP that supports http/https.request
Refs: #57872

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 3, 2025
joyeecheung commented Jul 3, 2025
View reviewed changes
Comment thread test/common/proxy-server.js
const child = spawn(...args);
child.stderr.setEncoding('utf8');
child.stderr.on('data', (data) => {
console.error('[STDERR]', data);

joyeecheung Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These logs are added for debugging, similar to what the test/common/inspector-helper.js does, otherwise the tests can be difficult to debug when they fail with no output from the child and I found myself constantly adding these logs. Would be good to have them if they ever fail/flake in the CI, otherwise it'd be a pain to add them back and forth.

joyeecheung added the review wanted PRs that need reviews. label Jul 4, 2025

codecov Bot commented Jul 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (049664b) to head (ff6ba64).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58950      +/-   ##
==========================================
+ Coverage   90.06%   90.09%   +0.03%     
==========================================
  Files         645      645              
  Lines      189130   189130              
  Branches    37094    37098       +4     
==========================================
+ Hits       170339   170405      +66     
+ Misses      11511    11461      -50     
+ Partials     7280     7264      -16

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca approved these changes Jul 5, 2025
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

joyeecheung mentioned this pull request Jul 7, 2025
Merged
2 tasks
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2025

nodejs-github-bot commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67915/

nodejs-github-bot commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67925/

nodejs-github-bot commented Jul 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67931/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2025
joyeecheung removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2025
joyeecheung reopened this Jul 15, 2025

joyeecheung commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

Superseded by #58980

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL