FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,permission: add support to permission.has(addon) by RafaelGSS · Pull Request #58951 · nodejs/node · GitHub

/ node Public

src,permission: add support to permission.has(addon) - #58951

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:add-allow-addon-support
Jul 7, 2025
ConversationCommits (1)ChecksFiles changed
Merged

src,permission: add support to permission.has(addon)#58951
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:add-allow-addon-support

Conversation

RafaelGSS commented Jul 3, 2025

Copy link
Copy Markdown
Member

This fixes the permission.has('addon') when --allow-addons is passed

RafaelGSS added the permission Issues and PRs related to the Permission Model label Jul 3, 2025

nodejs-github-bot commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 3, 2025

codecov Bot commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (aad9030) to head (3ea7607).
⚠️ Report is 120 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58951      +/-   ##
==========================================
- Coverage   89.96%   89.54%   -0.42%     
==========================================
  Files         640      641       +1     
  Lines      188454   188481      +27     
  Branches    36892    36670     -222     
==========================================
- Hits       169546   168782     -764     
- Misses      11608    12362     +754     
- Partials     7300     7337      +37
Files with missing lines Coverage Δ
src/env.cc 80.56% <100.00%> (-0.31%) ⬇️
src/permission/addon_permission.cc 100.00% <100.00%> (ø)
src/permission/permission.cc 80.41% <100.00%> (+0.41%) ⬆️
src/permission/permission.h 83.33% <ø> (ø)

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 4, 2025
RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 4, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025

nodejs-github-bot commented Jul 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67837/

nodejs-github-bot commented Jul 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67858/

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
nodejs-github-bot merged commit c5c6965 into nodejs:main Jul 7, 2025

nodejs-github-bot commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in c5c6965

RafaelGSS added a commit that referenced this pull request Jul 8, 2025
src,permission: add support to permission.has(addon)
ed966a0 
PR-URL: #58951
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
github-actions Bot mentioned this pull request Jul 8, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Jul 8, 2025
2025-07-09, Version 24.4.0 (Current)
5576dec 
Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993
RafaelGSS pushed a commit that referenced this pull request Jul 9, 2025
2025-07-09, Version 24.4.0 (Current)
c4169cb 
Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
src,permission: add support to permission.has(addon)
2ceccf5 
PR-URL: #58951
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
src,permission: add support to permission.has(addon)
2b973a6 
PR-URL: #58951
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 27, 2025
src,permission: add support to permission.has(addon)
48003e8 
PR-URL: #58951
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
github-actions Bot mentioned this pull request Jul 28, 2025
Merged
aduh95 added a commit that referenced this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS)
4c1b52e 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Jul 31, 2025
2025-07-31, Version 22.18.0 'Jod' (LTS)
c9ff1ae 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Jul 31, 2025
2025-07-31, Version 22.18.0 'Jod' (LTS)
5acb923 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
mete0rfish pushed a commit to mete0rfish/node-contribute that referenced this pull request Aug 9, 2025
2025-07-31, Version 22.18.0 'Jod' (LTS)
159aa69 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

IlyasShabi IlyasShabi approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL