test: WPT for Wasm jsapi including new ESM Integration tests by guybedford · Pull Request #59034 · nodejs/node · GitHub

This adds the jsapi test suite for WebAssembly including the new ESM Integration jsapi tests from WebAssembly/esm-integration#110 with upstream PR in web-platform-tests/wpt#53718.

Tests for string builtins and namespaceInstance are pending #59020 and #59024 respectively.

Review requested:

@nodejs/web-standards

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (0474a27) to head (0be51d5).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59034      +/-   ##
==========================================
- Coverage   91.54%   89.69%   -1.86%     
==========================================
  Files         351      692     +341     
  Lines      147748   214167   +66419     
  Branches    23240    41109   +17869     
==========================================
+ Hits       135258   192087   +56829     
- Misses      12236    14145    +1909     
- Partials      254     7935    +7681

see 463 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

out/Release/node --experimental-wasm-modules /repo/node/test/wpt/test-wasm-jsapi.mjs
(node:83231) Warning: Failed to load the ES module: /repo/node/test/fixtures/es-modules/globals.js. Make sure to set "type": "module" in the nearest package.json file or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/modules/run_main:107
    triggerUncaughtException(
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  ok(e instanceof WebAssembly.CompileError)

    at file:///repo/node/test/wpt/test-wasm-jsapi.mjs:13:3 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '==',
  diff: 'simple'
}

/repo/node/test/fixtures/es-modules/globals.js:5
export { i32_value as '🚀i32_value' }
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (node:internal/modules/cjs/loader:1762:18)
    at Module._compile (node:internal/modules/cjs/loader:1803:20)
    at Module._extensions..js (node:internal/modules/cjs/loader:1969:10)
    at Module.load (node:internal/modules/cjs/loader:1552:32)
    at Module._load (node:internal/modules/cjs/loader:1354:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:325:3)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:230:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:430:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:639:26)

@miladfarca FYI it looks like some of these tests are failing on Linux s390x.

So, it seems it this is for round-tripping v128:

  [UNEXPECTED_FAILURE][FAIL] v128 globals should work correctly in WebAssembly-to-WebAssembly imports
  assert_equals: expected 1 but got 67108864
      at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-linuxone/test/fixtures/wpt/wasm/jsapi/esm-integration/mutable-global-sharing.tentative.any.js:52:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
  Command: /home/iojs/build/workspace/node-test-commit-linuxone/out/Release/node --experimental-wasm-modules undefined 'esm-integration/mutable-global-sharing.tentative.any.js'

The value returned is consistent with big endian handling of the SIMD path, which formally speaking is a V8 bug since Wasm is supposed to have little endian behaviours.

There is a SIMD test for this in V8, but V8 only runs x390x simulator assuming VECTOR_ENHANCE_FACILITY_2, which might not be available on our hardware?

I've pushed a temporary commit which replicates the internal simd test suite case in question, to see if that also fails on the hardware. If so, then this is a V8 bug on s390x separate to the WPT work here.

I can confirm the same failure, so this is a v8 bug for Wasm SIMD on s390x - https://ci.nodejs.org/job/node-test-commit-aix/61569/nodes=aix72-power9/testReport/junit/(root)/parallel/test_wasm_simd_global/.

I've added a specific skip for this environment to resolve the issue, given this is not a Node.js or WPT issue.

I can confirm the same failure, so this is a v8 bug for Wasm SIMD on s390x - https://ci.nodejs.org/job/node-test-commit-aix/61569/nodes=aix72-power9/testReport/junit/(root)/parallel/test_wasm_simd_global/.

FWIW AIX is not Linux s390x, but both are big endian platforms.

This patch should fix the issue on big endian (which includes s390x): http://crrev.com/c/7704213

Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: nodejs/node#59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082}

Unfortunately it seems like that patch did not fix the error in the CI here. Let me know if I should bring back the skip or if we should wait for a further follow-on.

Oh nvm I misread the commit being shown on this PR as being included here... sorry for confusion will continue with the final CI here further based on the skipped test, to be corrected later.

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: nodejs#59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4

This patch should fix the issue on big endian (which includes s390x): http://crrev.com/c/7704213

#62449

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: #59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: #62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: nodejs#59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: nodejs#62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: #59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: #62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: nodejs#59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: nodejs#62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: #59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 Refs: v8/v8@cf1bce4 PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: #59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 Refs: v8/v8@cf1bce4 PR-URL: #61898 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> (cherry picked from commit cc5a331)

Tests are failing on v24.x-staging with this change, it would require a manual backport PR if we want it on Node.js 24

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: nodejs#59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: nodejs#62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: [wasm] Fix S128Const on big endian Since http://crrev.com/c/2944437 globals are no longer little endian enforced. S128Const handling in the initializer needs to take this into account and byte reverse values which are hard coded in little endian order. This is currently causing failures on Node.js upstream: #59034 (comment) Change-Id: Ifcc9ade93ee51565ab19b16e9dadf0ff5752f7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7704213 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#106082} Refs: v8/v8@cf1bce4 PR-URL: #62449 Refs: v8/v8@cf1bce4 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 11, 2025

guybedford force-pushed the wpt-wasm-jsapi branch from 41d1b4b to aacf993 Compare July 11, 2025 16:07

guybedford force-pushed the wpt-wasm-jsapi branch from 7cb3437 to 7e36e0d Compare March 23, 2026 19:52

legendecas reviewed Mar 23, 2026

View reviewed changes

Comment thread test/wpt/status/wasm/jsapi.json Outdated

legendecas approved these changes Mar 23, 2026

View reviewed changes

legendecas added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 23, 2026

This comment was marked as outdated.

Sign in to view

guybedford force-pushed the wpt-wasm-jsapi branch from fb0aaa0 to bfe4371 Compare March 26, 2026 21:17

richardlau mentioned this pull request Mar 26, 2026

deps: V8: cherry-pick cf1bce40a5ef #62449

Merged

test: wpt for Wasm jsapi including new ESM Integration tests

3bf8ee8

guybedford closed this Mar 31, 2026

targos mentioned this pull request Apr 3, 2026

deps: update V8 to 14.6 #61898

Closed

RafaelGSS mentioned this pull request Apr 27, 2026

2026-05-05, Version 26.0.0 (Current) #62526

Merged

aduh95 added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label May 7, 2026

test: WPT for Wasm jsapi including new ESM Integration tests by guybedford · Pull Request #59034 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: WPT for Wasm jsapi including new ESM Integration tests - #59034

test: WPT for Wasm jsapi including new ESM Integration tests#59034guybedford wants to merge 10 commits intonodejs:mainnodejs/node:mainfrom guybedford:wpt-wasm-jsapiguybedford/node:wpt-wasm-jsapiCopy head branch name to clipboard

Conversation

guybedford commented Jul 11, 2025

Uh oh!

nodejs-github-bot commented Jul 11, 2025

Uh oh!

codecov Bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

panva commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

richardlau commented Mar 25, 2026

Uh oh!

guybedford commented Mar 25, 2026

Uh oh!

This comment was marked as outdated.

guybedford commented Mar 25, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

richardlau commented Mar 26, 2026

Uh oh!

miladfarca commented Mar 26, 2026

Uh oh!

This comment was marked as outdated.

guybedford commented Mar 26, 2026

Uh oh!

guybedford commented Mar 26, 2026

Uh oh!

richardlau commented Mar 26, 2026

Uh oh!

aduh95 commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

test: WPT for Wasm jsapi including new ESM Integration tests#59034
guybedford wants to merge 10 commits into
nodejs:mainfrom
guybedford:wpt-wasm-jsapi

codecov Bot commented Jul 11, 2025 •
edited
Loading

panva commented Mar 23, 2026 •
edited
Loading